On Mon, 15 Jan 2024 14:38:58 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> For gcc toolchains in ALLOW_ABSOLUTE_PATHS_IN_OUTPUT=False builds, this PR >> finds the location of the gcc system include paths, and adds >> -fdebug-prefix-map flags to map them to a standard location. Thus making the >> debuginfo and resulting libraries reproducible when using DevKits in >> different path locations. > > Andrew Leonard has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - 8323667: Library debug files contain non-reproducible full gcc include > paths > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> > - 8323667: Library debug files contain non-reproducible full gcc include > paths > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> > - Merge branch 'master' of github.com:openjdk/jdk into gcc_debug_map > - 8323667: Library debug files contain non-reproducible full gcc include > paths > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> Have you checked with `strings` if there are any other hard-coded paths, or are these really the only ones left? make/autoconf/flags-cflags.m4 line 194: > 192: # Add gcc system include mapping => /usr/local/gcc_include > 193: # Find location of stddef.h using build C compiler > 194: GCC_SYSTEM_INCLUDE=`$ECHO "#include <stddef.h>" | $CC > $GCC_SYSROOT_PARAM -v -E - 2>&1 | $GREP stddef | $TAIL -1 | $TR -s " " | $CUT > -d'"' -f2` Don't we have a properly setup `CFLAGS` here that you can use, instead of having to specify the sysroot manually? ------------- PR Comment: https://git.openjdk.org/jdk/pull/17399#issuecomment-1893691865 PR Review Comment: https://git.openjdk.org/jdk/pull/17399#discussion_r1453387790
