On Wed, 17 Jan 2024 13:52:39 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> > > So `$CC $CFLAGS` did not work? > > > > > > @magicus So I purposely chose SYSROOT_CFLAGS thinking that would all that > > would be needed, but I think you're correct, I should use the complete > > CFLAGS in case a custom user extension include may have pointed at some > > other include path. I have updated and tested successfully with > > CFLAGS_JDKLIB. Ready for re-review, Thanks > > Magnus specifically meant `$CFLAGS`. It's set to `"$MACHINE_FLAG > $SYSROOT_CFLAGS $USER_CFLAGS"` in `flags.m4` and meant to contain relevant > flags for running checks in configure. I don't think `$CFLAGS_JDKLIB` is > appropriate here even if it should work. Ah, I thought CFLAGS was only set in the gmk files...? i'll give it a try thanks. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17399#issuecomment-1896089971
