On Tue, 16 Jan 2024 14:12:43 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> For gcc toolchains in ALLOW_ABSOLUTE_PATHS_IN_OUTPUT=False builds, this PR >> finds the location of the gcc system include paths, and adds >> -fdebug-prefix-map flags to map them to a standard location. Thus making the >> debuginfo and resulting libraries reproducible when using DevKits in >> different path locations. > > Andrew Leonard has updated the pull request incrementally with one additional > commit since the last revision: > > 8323667: Library debug files contain non-reproducible full gcc include paths > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> I think this looks ok but could you split the longer lines to make side by side comparisons easier in the future? ------------- PR Review: https://git.openjdk.org/jdk/pull/17399#pullrequestreview-1824910606
