On Tue, 16 Jan 2024 18:53:23 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> I think it might operate on both, but I'm not sure. But my thinking was that >> JAVA_TARGETS depended on GENSRC_TARGETS, which in turn would make sure that >> all source code was properly generated. >> >> Am I missing something? > > Unnecessarily depending on too much hurts build performance. I would like > @lahodaj to help us understand what the tool actually needs. This tool only uses sources, it will not use the compiled classfiles. So, running it at a point where all sources are generated should be sufficient. Most important are generated module-infos, but other sources may in some cases be significant as well. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17402#discussion_r1456176633