On Thu, 18 Jan 2024 07:25:48 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> Uh, sorry for not being precise. I was talking of the 
>> `JavadocElementList`/`jdk.javadoc-gendata` - that does not use classfiles, 
>> only sources. `jdk.compiler-gendata`/`ct.sym` generation surely does use 
>> (all) the new JDK classfiles. Sorry for the confusion.
>
> @lahodaj Just to be absolutely clear: In `jdk.javadoc-gendata`, we're calling 
> two tools: Not only `JavadocElementList` (which only requires source, not 
> class files), but also `CreateSymbols build-javadoc-data`. Can you confirm 
> that this too only requires sources?
> 
> (I take it that this usage is different from `CreateSymbols build-ctsym` as 
> called in `jdk.compiler-gendata`.)

Looking at `make/modules/jdk.javadoc/Gendata.gmk` the recipe never references 
`$(JDK_OUTPUTDIR)/modules/`, the output dir where the compiled classes are 
located. It only references the output of `$(call GetModuleSrcPath)` (and some 
static src dirs), so I'm pretty confident that this is correct.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17402#discussion_r1457474979

Reply via email to