On Wed, 17 Jan 2024 19:44:27 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:
>> I take that back, jdk.javadoc-gendata should depend on `$(GENSRC_TARGETS)`, >> jdk.compiler-gendata still needs `$(JAVA_TARGETS)` as the recipe for that >> target seems to actually use compiled classes. > > Uh, sorry for not being precise. I was talking of the > `JavadocElementList`/`jdk.javadoc-gendata` - that does not use classfiles, > only sources. `jdk.compiler-gendata`/`ct.sym` generation surely does use > (all) the new JDK classfiles. Sorry for the confusion. @lahodaj Just to be absolutely clear: In `jdk.javadoc-gendata`, we're calling two tools: Not only `JavadocElementList` (which only requires source, not class files), but also `CreateSymbols build-javadoc-data`. Can you confirm that this too only requires sources? (I take it that this usage is different from `CreateSymbols build-ctsym` as called in `jdk.compiler-gendata`.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17402#discussion_r1457030105
