On Fri, 15 Mar 2024 07:15:55 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Eclipse Shared Workspaces share the same directory as the JDK itself, which >> does not make much sense since there can be multiple different >> configurations of the JDK which Eclipse does depend on (as minimalistic as >> it is), and there is no one true JDK configuration, unlike what this setting >> suggests. This feature was created when I was much less familiar with the >> structure of how the JDK handles different builds, and should be removed > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Merge branch 'openjdk:master' into patch-15 > - Refresh documentation > - Remove Shared Workspaces entirely > - Remove shared targets > - 8326964 make/ide/eclipse/CreateWorkspace.gmk line 192: > 190: # make dist-clean omitted since it would delete the Workspace as well > 191: # $1_PLAIN_MAKE_TARGETS += reconfigure > 192: # $1_PLAIN_MAKE_TARGETS += dist-clean Why leave these additions commented out and not just remove them? If you think the comment is important, you can just put it above the PLAIN_MAKE_TARGETS definition. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18046#discussion_r1526233930
