On Mon, 18 Mar 2024 09:18:40 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> .gitignore line 22: >> >>> 20: /.settings/ >>> 21: /.project >>> 22: /.classpath >> >> `.project` is repeated so that is fine to remove, but why are you removing >> the other two? `.cproject` sounds like it could come from CDT. > > With the Shared Workspaces removed, the Workspace created no longer exists in > the JDK's top level source directory. This means the .gitignore entries are > now obsolete, and can be removed, since they only ignore .cproject and > .classpath in the top level source directory. They were added way back when I > introduced support for Eclipse, and was less familiar with how multiple > different JDK builds are contained Side tangent: How are the Workspaces for the other IDEs set up? Are they contained entirely in the ide subdirectory in the build directory or do they end up leaving their metadata in the top level directory like the Shared Workspaces used to do? I plan to improve Eclipse support over time, and these details might potentially be important to that effort ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18046#discussion_r1528161453
