On Mon, 18 Mar 2024 09:07:26 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove SHARED definition in Main.gmk > > .gitignore line 22: > >> 20: /.settings/ >> 21: /.project >> 22: /.classpath > > `.project` is repeated so that is fine to remove, but why are you removing > the other two? `.cproject` sounds like it could come from CDT. With the Shared Workspaces removed, the Workspace created no longer exists in the JDK's top level source directory. This means the .gitignore entries are now obsolete, and can be removed, since they only ignore .cproject and .classpath in the top level source directory. They were added way back when I introduced support for Eclipse, and was less familiar with how multiple different JDK builds are contained ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18046#discussion_r1528154027
