On Thu, 28 Mar 2024 18:41:03 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix jni includes > > Hamlin, thank you for working on this. I think integrating a sub-set of SLEEF > is valuable (not all of it makes sense e.g., DFT part). My recommendation > would be to focus on a PR that integrates the required source, rather than > taking steps towards that. > > AFAICT from browsing prior comments "integrate the source" appears to be the > generally preferred solution, but there is some understandable hesitancy > about legal aspects. IIUC from what you say this is a technically feasible > and maintainable solution. As said here: > >> We (Oracle Java Platform Group) can handle the required "paperwork > https://github.com/openjdk/jdk/pull/16234#issuecomment-1823335443 Thanks @PaulSandoz for your comment and suggestion. I will work on the solution which integrates the source of sleef into jdk. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18294#issuecomment-2031671597
