On Wed, 3 Apr 2024 14:40:42 GMT, Hamlin Li <m...@openjdk.org> wrote: > Hi, > Can you help to review the patch? > This pr is based on previous work and discussion in [pr > 16234](https://github.com/openjdk/jdk/pull/16234), [pr > 18294](https://github.com/openjdk/jdk/pull/18294). > > Compared with previous prs, the major change in this pr is to integrate the > source of sleef (for the steps, please check > `src/jdk.incubator.vector/linux/native/libvectormath/README`), rather than > depends on external sleef things (header or lib) at build or run time. > Besides of this change, also modify the previous changes accordingly, e.g. > remove some uncessary files or changes especially in make dir of jdk. > > Besides of the code changes, one important task is to handle the legal > process. > > Thanks!
make/modules/jdk.incubator.vector/Lib.gmk line 44: > 42: $(eval $(call SetupJdkLibrary, BUILD_LIBVECTORMATH, \ > 43: NAME := vectormath, \ > 44: CFLAGS := $(CFLAGS_JDKLIB) -Wno-error=unused-function, \ Should the unused-function be passed in using `DISABLE_WARNINGS_*` instead? src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8601: > 8599: } > 8600: } else { > 8601: log_info(library)("Failed to load native vector math library!"); Include the `ebuf` message? The corresponding x86_64 code could also use a log message for the error case. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18605#discussion_r1552502695 PR Review Comment: https://git.openjdk.org/jdk/pull/18605#discussion_r1552499482