On Fri, 5 Apr 2024 14:14:35 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> This is the pinnacle of the recent stream of refactorings in the build >> system. This patch introduces a more abstract concept of "JDK_LIBS", where >> only the library name (e.g. "java" or "java.desktop:jawt") is specified, and >> the build system turns this into suitable linker flags: `-ljawt -L<correct >> path>` or `jawt.lib -libpath:<correct path>`, depending on linker. It will >> also automatically create proper dependencies. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Fix libfallbackLinker I apologize for bouncing this one back and forth between open and draft. I thought I had verified everything but then I discovered two missing includes on Windows. And then GHA failed on linux-x86 for libfallbackLinker. Now these are fixed; I have confirmed that Windows builds properly on Oracle's CI system, and that libfallbackLinker works locally on a linux-x86 build, so I'm just waiting for GHA to confirm this. I have also run tier1 + tier2 on Oracle's CI system for windows x64, linux x64/aarch64 and macos x64/aarch64, without failures. (The Windows run is still waiting for a few tests to finish.) Furthermore I have checked with COMPARE_BUILD, and the only differences I can see is related to library linking: On macOS and Linux, most libraries linked with "-ljvm -ljava" as default before, regardless of if they were needed or not. Now we only link with these libraries if needed, so this changes the bit-by-bit comparison for almost all libraries. On Windows, there was just a few libraries that had dependency changes. As far as I can tell, all changes discovered were related to the change in dynamic library dependencies. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18649#issuecomment-2039920478
