On Fri, 5 Apr 2024 18:32:54 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix libfallbackLinker > > make/common/JdkNativeCompilation.gmk line 206: > >> 204: $$(eval $$(call ResolveLibPath,$1,$2)) >> 205: >> 206: $1_EXTRA_HEADER_DIRS += $$($1_$2_MODULE):lib$$($1_$2_NAME) > > I think the top level comment need to be clearer about JDK_LIB implicitly > setting EXTRA_HEADER_DIRS. It is documented on line 175, for AddJdkLibrary. I added it to SetupJdkNativeCompilation as well, not sure if that was what you meant. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18649#discussion_r1559462557
