On Wed, 10 Apr 2024 13:41:53 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> make/common/JdkNativeCompilation.gmk line 206: >> >>> 204: $$(eval $$(call ResolveLibPath,$1,$2)) >>> 205: >>> 206: $1_EXTRA_HEADER_DIRS += $$($1_$2_MODULE):lib$$($1_$2_NAME) >> >> I think the top level comment need to be clearer about JDK_LIB implicitly >> setting EXTRA_HEADER_DIRS. > > It is documented on line 175, for AddJdkLibrary. I added it to > SetupJdkNativeCompilation as well, not sure if that was what you meant. That is what I meant, as that is the public API. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18649#discussion_r1559473879
