On Sat, 20 Jul 2024 00:20:19 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
> Please review this PR that strips the `.llvm_addrsig` section from JDK and > hotspot `.a` static libraries when building with clang. Please see > https://bugs.openjdk.org/browse/JDK-8336849 description for details. Thanks for looking into this > This all seems very odd to me. Where do we set `--icf=safe` to the linker, > and why? Why has this not shown up earlier? As described in earlier comment, `-Wl,--icf=safe` could be specified when linking the launcher executable using `libjvm.a` and etc. That's the #2 step described in the comment. I found following links with some detaills on `--icf=safe`: - https://nxmnpg.lemoda.net/1/ld.lld (search for `icf`) - https://github.com/rui314/mold/issues/484 (some useful info, not for lld) ------------- PR Comment: https://git.openjdk.org/jdk/pull/20265#issuecomment-2269520892
