On Wed, 7 Aug 2024 15:12:30 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> - Incorporate comment suggestion from @magicus. Also applied some >> additional minor adjustments on top of the suggestion. > > make/common/native/Link.gmk line 114: > >> 112: # Linking with '-Wl,--icf=safe' using objects created by 'ld >> -r' may not work >> 113: # and could cause errors like the following: >> 114: # ld: --icf=safe conservatively ignores SHT_LLVM_ADDRSIG >> [...] with sh_link=0 (likely created using objcopy or ld -r) > > I'd recommend rephrasing the comment somewhat, like > > Suggestion: > > # 'ld -r' might fail to update the .llvm_addrsig section, and this > will cause subsequent > # calls to lld to fail when linking with this library, so remove > that section. > > > (adjust line lengths if > 80) Suggestion applied, with some minor additional adjustments. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20265#discussion_r1707851591
