On Wed, 21 Aug 2024 13:02:23 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Add a make target to generate an Xcode project file for Hotspot. >> >> This PR is the result of a cooperation between me and @gerard-ziemski. >> Gerard developed the original Xcode generator (as a stand-alone project in >> https://github.com/gerard-ziemski/xcode), and I have written the build >> system "glue" to integrate it, and refactored the code to modern JDK >> standards. >> >> Usage: Run `make hotspot-xcode-project`, and an Xcode project file will be >> generated in `build/$BUILD/xcode`. You can also have this automatically >> opened in Xcode by `make open-hotspot-xcode-project` (but note that for >> repeated runs of this, `make open-hotspot-xcode-project-only` is greatly >> preferred). > > make/common/native/Link.gmk line 203: > >> 201: >> 202: # This is for IDE integration purposes only, and is not normally >> generated >> 203: $1_LD_JSON := >> $$(MAKESUPPORT_OUTPUTDIR)/compile-commands/$$($1_NAME)-ldflags.txt > > Should this be called `JSON` if it's not actually a json file? In the other > file it's referenced as a LINKER_FLAGS_FILE. Good catch, thanks. Too much copy/paste. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20564#discussion_r1725039988
