On Wed, 21 Aug 2024 13:06:00 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Add a make target to generate an Xcode project file for Hotspot. >> >> This PR is the result of a cooperation between me and @gerard-ziemski. >> Gerard developed the original Xcode generator (as a stand-alone project in >> https://github.com/gerard-ziemski/xcode), and I have written the build >> system "glue" to integrate it, and refactored the code to modern JDK >> standards. >> >> Usage: Run `make hotspot-xcode-project`, and an Xcode project file will be >> generated in `build/$BUILD/xcode`. You can also have this automatically >> opened in Xcode by `make open-hotspot-xcode-project` (but note that for >> repeated runs of this, `make open-hotspot-xcode-project-only` is greatly >> preferred). > > make/ide/xcode/hotspot/CreateXcodeProject.gmk line 40: > >> 38: >> 39: PROJECT_MAKER_DIR := $(TOPDIR)/make/ide/xcode/hotspot >> 40: TOOLS_OUTPUTDIR := $(MAKESUPPORT_OUTPUTDIR)/ide/xcode > > I would have expected this to go in `$(BUILDTOOLS_OUTPUTDIR)`. Not that it > matters that much. It only really affects which clean target removes what. For me, buildtools means "binaries we create to help with the build of the product" (basically specialized compilers). Generating an IDE project is a different kind of story. Given your question, I checked what the Visual Studio java tool did. It created it's output in `$(HOTSPOT_OUTPUTDIR)/support/ide_classes`. That's not really better. (I think it should go to `$(MAKESUPPORT_OUTPUTDIR)/ide/visualstudio`.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20564#discussion_r1725046796
