On Wed, 21 Aug 2024 14:07:00 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Add a make target to generate an Xcode project file for Hotspot. >> >> This PR is the result of a cooperation between me and @gerard-ziemski. >> Gerard developed the original Xcode generator (as a stand-alone project in >> https://github.com/gerard-ziemski/xcode), and I have written the build >> system "glue" to integrate it, and refactored the code to modern JDK >> standards. >> >> Usage: Run `make hotspot-xcode-project`, and an Xcode project file will be >> generated in `build/$BUILD/xcode`. You can also have this automatically >> opened in Xcode by `make open-hotspot-xcode-project` (but note that for >> repeated runs of this, `make open-hotspot-xcode-project-only` is greatly >> preferred). > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Rename $1_LD_JSON to $1_LDFLAGS_FILE Thanks for the work done. LGTM. ------------- Marked as reviewed by azafari (Committer). PR Review: https://git.openjdk.org/jdk/pull/20564#pullrequestreview-2253690909
