On Fri, 16 Aug 2024 09:45:59 GMT, Hamlin Li <m...@openjdk.org> wrote:
>> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update README to include RISC-V > >> With this solution I would recommend putting the script next to the Sleef >> source tree instead of in make/devkit/. > >> The normal JDK build will just use the committed pre-generated headers. > >> Not because I didn't think it was feasible to implement, but because of the >> future maintenance burden. > > I agree with @erikj79, in particular the above 3 points. > > Shall we be ready to move forward? Or we're still blocked by some other > issues, such as legal process? @Hamlin-Li We now have the necessary approvals in place for the new plan to include all of SLEEF (and the pre-generated header files) in the JDK. I (or somebody else from Oracle) will need to be the one committing/contributing the actual SLEEF code itself in the end. Can you take on the work of implementing the actual plan/logic and make sure it's all effectively ready for integration? ------------- PR Comment: https://git.openjdk.org/jdk/pull/19185#issuecomment-2313650531
