On Tue, 27 Aug 2024 22:37:01 GMT, Mikael Vidstedt <[email protected]> wrote:
>> @vidmik Thanks for pushing forward this work. >> Sure, I can take the work. >> >> Just several questions, Sorry, as this is the first time I do this kind of >> work in jdk. >> In this pr, we already have the pre-generated sleef files and the scripts to >> generate it, what we are missing is the sleef original file (in my >> understanding, we also need to checkin them), besides of sleef original >> files, do we need any other files or document? In particular, do you mind to >> clarify further about `plan/logic` mentioned above? > > @Hamlin-Li Thank you for taking it on! > > Part of the work is figuring out exactly what exactly we want - see the > comments from @erikj79 and @theRealAph in this PR for inspiration. In > particular, we'll want to include all or part of the SLEEF sources in the > JDK, but we'll likely also want some additional build scripts and > documentation to make it easy for developers to reproduce and update going > forward. This could probably be based on the README and createSleef script. @vidmik @Hamlin-Li I kind of hijacked this... I created the necessary build system changes to update the generated sleef code. At that point, also importing the actual source code was just a trivial addition. The new PR is here: https://github.com/openjdk/jdk/pull/20781 I think it implements everything we've talked about here, in the way I understood consensus to be. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19185#issuecomment-2319340361
