On Mon, 7 Apr 2025 09:18:08 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> Windows can create short names for directories that contain spaces in the
> name.
>
> However, where short name creation was previously enabled by default, it no
> longer seems to be in recent version of Windows (the default setting is
> instead 'per volume', and the default for each volume is 'off').
>
> We should check that the output paths of these utility macros are actually
> space-free, and emit an error otherwise. We should also add additional
> documentation about short names, and the short name creation setting to
> doc/building.md.
>
> When testing this in several different cases with path including spaces that
> either had or had not a short name, it became apparent that the current
> handling of such cases were not ... optimal. Hence some bug fixes were needed
> to properly handle such cases.
This is a great change. Just a minor grammar nit in the docs.
doc/building.md line 117:
> 115: upper and lower case letters.
> 116:
> 117: Failure to follow this procedure might result in hard-to-debug build
We are listing 2 bullets for Cygwin here so I think plural sounds better.
Suggestion:
Failure to follow these procedures might result in hard-to-debug build
-------------
PR Review: https://git.openjdk.org/jdk/pull/24483#pullrequestreview-2822221921
PR Review Comment: https://git.openjdk.org/jdk/pull/24483#discussion_r2077896621
