> Windows can create short names for directories that contain spaces in the 
> name.
> 
> However, where short name creation was previously enabled by default, it no 
> longer seems to be in recent version of Windows (the default setting is 
> instead 'per volume', and the default for each volume is 'off').
> 
> We should check that the output paths of these utility macros are actually 
> space-free, and emit an error otherwise. We should also add additional 
> documentation about short names, and the short name creation setting to 
> doc/building.md.
> 
> When testing this in several different cases with path including spaces that 
> either had or had not a short name, it became apparent that the current 
> handling of such cases were not ... optimal. Hence some bug fixes were needed 
> to properly handle such cases.

Magnus Ihse Bursie has updated the pull request incrementally with one 
additional commit since the last revision:

  Fix typo
  
  Co-authored-by: Erik Joelsson <37597443+erik...@users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24483/files
  - new: https://git.openjdk.org/jdk/pull/24483/files/210aa040..45a94bfe

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24483&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24483&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/24483.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24483/head:pull/24483

PR: https://git.openjdk.org/jdk/pull/24483

Reply via email to