On Wed, 7 May 2025 20:26:13 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> Windows can create short names for directories that contain spaces in the 
>> name.
>> 
>> However, where short name creation was previously enabled by default, it no 
>> longer seems to be in recent version of Windows (the default setting is 
>> instead 'per volume', and the default for each volume is 'off').
>> 
>> We should check that the output paths of these utility macros are actually 
>> space-free, and emit an error otherwise. We should also add additional 
>> documentation about short names, and the short name creation setting to 
>> doc/building.md.
>> 
>> When testing this in several different cases with path including spaces that 
>> either had or had not a short name, it became apparent that the current 
>> handling of such cases were not ... optimal. Hence some bug fixes were 
>> needed to properly handle such cases.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Regenerate html file

Marked as reviewed by erikj (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24483#pullrequestreview-2823166416

Reply via email to