On Fri, 1 May 2026 15:37:12 GMT, Kevin Walls <[email protected]> wrote:

> This implements "jcmd on core files" for Linux, and for MiniDumps on Windows 
> (MacOS is "future work").
> jcmd "revives" the VM memory and .so/.dll from the core/minidump, and runs 
> the existing native diagnostic command parser and command implementations.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Not a a full revew, just few comments about est groups.

test/hotspot/jtreg/TEST.groups line 64:

> 62: hotspot_serviceability = \
> 63:   serviceability \
> 64:   serviceability/revival

No need to add this group here.

test/hotspot/jtreg/TEST.groups line 618:

> 616: 
> 617: tier1_serviceability = \
> 618:   serviceability/revival \

No need to add this group here.

test/hotspot/jtreg/TEST.groups line 675:

> 673: hotspot_tier2_serviceability = \
> 674:   serviceability/ \
> 675:   serviceability/revival \

No need to add this group here.
Also it just add it in tier1 and tier2.

-------------

Changes requested by lmesnik (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/31011#pullrequestreview-4215567422
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3177284334
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3177284209
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3177284820

Reply via email to