On Fri, 15 May 2026 11:45:49 GMT, Kevin Walls <[email protected]> wrote:
>> src/jdk.attach/linux/native/revivalhelper/elffile.cpp line 1: >> >>> 1: /* >> >> HotSpot and SA already have ELF parser. Can we unify them? > > It is important that this jcmd on cores feature is independent of the SA, > because it is something that could replace the SA in time. With a few more > jcmds we can offer most SA features. Can discuss the parity somewhere else, > but it would be wrong to tie this to the SA. > > I have not expanded jdk.hotspot.agent/.../salibelf.c to cover everything > needed here, but it may duplicate some concepts. Being in a different module > it's not exactly easy or good for this to depend on salibelf as we want to > keep them independent. I understand about SA, but can we share the code between jcmd and HotSpot? HotSpot has ELF parser and some utilities for it. Ideally it is better to use libelf by elfutils. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3248293416
