On Sat, 2 May 2026 10:14:36 GMT, Yasumasa Suenaga <[email protected]> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   feedback and test update
>
> src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachineCoreDump.java
>  line 247:
> 
>> (failed to retrieve contents of file, check the PR for context)
> We can simplify this method like:
> 
> Suggestion:
> 
>         try (var reader = new InputStreamReader(is, UTF_8)))) {
>             return reader.readAllAsString();
>         }

Thanks, am finally updating this again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r4124779481

Reply via email to