On Fri, 5 Jun 2026 08:02:18 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Andrew Haley has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 128 commits: >> >> - Merge https://github.com/openjdk/jdk into JDK-8134940 >> - Review comments >> - Review comments >> - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into >> JDK-8134940 >> - Merge remote-tracking branch 'refs/remotes/origin/JDK-8134940' into >> JDK-8134940 >> - Review comments >> - Review comments >> - Remove misleading comment >> - Merge remote-tracking branch 'refs/remotes/origin/JDK-8134940' into >> JDK-8134940 >> - Add macros >> - ... and 118 more: https://git.openjdk.org/jdk/compare/ca52afa3...f9440fbb > > src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 463: > >> 461: Address(address target, relocInfo::relocType rtype = >> relocInfo::external_word_type); >> 462: >> 463: Address(Register base, RegisterOrConstant index, extend ext = lsl(0)) >> { > > OK, but do you need to do the same at the sibling constructor? > > > Address(Register r, Register r1, extend ext = lsl()) : > > > Maybe do this in separate PR, as it might affect (or fix bugs for) others? I really don't think this needs a separate PR, it's just for clarity. But on further inspection it's unnecessary. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3362754759
