On Mon, 8 Jun 2026 14:53:47 GMT, Andrew Haley <[email protected]> wrote:

>> src/hotspot/share/c1/c1_LIRGenerator.cpp line 3213:
>> 
>>> 3211:   }
>>> 3212: 
>>> 3213:   LIR_Opr result = notify ? new_register(T_INT) : 
>>> LIR_OprFact::intConst(0);
>> 
>> Looks like `increment_profile_ctr` expects `result` to be the register:
>> 
>> 
>>   Register dest = as_reg(dest_opr);
>> 
>> 
>> ...so passing `intConst(0)` would fail.
>
> Mmm, true. `notify` seems to have been initialized to `true` for many years. 
> Maybe I should just remove it now?

Ah, OK, cool. Yeah, either remove it completely, or just stop using it and 
`assert(notify, ...)` instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3380150276

Reply via email to