On Fri, 5 Jun 2026 08:00:00 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Andrew Haley has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 128 commits: >> >> - Merge https://github.com/openjdk/jdk into JDK-8134940 >> - Review comments >> - Review comments >> - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into >> JDK-8134940 >> - Merge remote-tracking branch 'refs/remotes/origin/JDK-8134940' into >> JDK-8134940 >> - Review comments >> - Review comments >> - Remove misleading comment >> - Merge remote-tracking branch 'refs/remotes/origin/JDK-8134940' into >> JDK-8134940 >> - Add macros >> - ... and 118 more: https://git.openjdk.org/jdk/compare/ca52afa3...f9440fbb > > src/hotspot/share/c1/c1_LIRGenerator.cpp line 3213: > >> 3211: } >> 3212: >> 3213: LIR_Opr result = notify ? new_register(T_INT) : >> LIR_OprFact::intConst(0); > > Looks like `increment_profile_ctr` expects `result` to be the register: > > > Register dest = as_reg(dest_opr); > > > ...so passing `intConst(0)` would fail. Mmm, true. `notify` seems to have been initialized to `true` for many years. Maybe I should just remove it now? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3374186449
