On Fri, 5 Jun 2026 07:43:09 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Andrew Haley has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 128 commits: >> >> - Merge https://github.com/openjdk/jdk into JDK-8134940 >> - Review comments >> - Review comments >> - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into >> JDK-8134940 >> - Merge remote-tracking branch 'refs/remotes/origin/JDK-8134940' into >> JDK-8134940 >> - Review comments >> - Review comments >> - Remove misleading comment >> - Merge remote-tracking branch 'refs/remotes/origin/JDK-8134940' into >> JDK-8134940 >> - Add macros >> - ... and 118 more: https://git.openjdk.org/jdk/compare/ca52afa3...f9440fbb > > src/hotspot/share/c1/c1_LIR.cpp line 1085: > >> 1083: masm->append_code_stub(overflow_stub()); >> 1084: } >> 1085: #endif > > Are we sure we are not emitting `LIR_OpIncrementCounter` for platforms where > `RANDOMIZED_PROFILE_CAPTURE` is `false`? Can we at least assert that on > `#else` branch here? Fixed. I `#ifdef`'d out the new code so this can't happen. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3374209568
