On Mon, 24 Aug 2026 11:42:23 GMT, Harshit Dhiman <[email protected]> wrote:

>> Port the Z garbage collector to s390.
>> 
>> The tier1 test case are passing using `-XX:+UseZGC` flag
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Harshit Dhiman has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   add some more comments

src/hotspot/cpu/s390/gc/z/z_s390.ad line 189:

> 187: 
> 188:     __ z_csg($oldval_temp$$Register, $newval_temp$$Register, mem_addr);
> 189:     if (VM_Version::has_LoadStoreConditional()) {

Although this check doesn't make that much sense, because I don't know if 
anyone is using z13 machine at all. But still if you want to put a check then 
please note that we need `has_LoadStoreConditional2` for `z_locghi`. 

Suggestion:

    if (VM_Version::has_LoadStoreConditional2()) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31984#discussion_r3849262295

Reply via email to