On Tue, 25 Aug 2026 04:15:57 GMT, Harshit Dhiman <[email protected]> wrote:

>> wait why don't you use `MacroAssembler::load_on_condition_imm_64` ? I think 
>> that's what you want to achieve here, right ?
>
>> Although this check doesn't make that much sense, because I don't know if 
>> anyone is using z13 machine at all. But still if you want to put a check 
>> then please note that we need `has_LoadStoreConditional2` for `z_locghi`.
> 
> I think it would be better to just remove it then if no one is using z13 
> machines.

No, for now just go ahead with MacroAssembler implementation. Later we can do 
the cleanup in macroAssembler file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31984#discussion_r3849578923

Reply via email to