On Tue, 25 Aug 2026 03:12:11 GMT, Amit Kumar <[email protected]> wrote:
>> src/hotspot/cpu/s390/gc/z/z_s390.ad line 189:
>>
>>> 187:
>>> 188: __ z_csg($oldval_temp$$Register, $newval_temp$$Register, mem_addr);
>>> 189: if (VM_Version::has_LoadStoreConditional()) {
>>
>> Although this check doesn't make that much sense, because I don't know if
>> anyone is using z13 machine at all. But still if you want to put a check
>> then please note that we need `has_LoadStoreConditional2` for `z_locghi`.
>>
>> Suggestion:
>>
>> if (VM_Version::has_LoadStoreConditional2()) {
>
> wait why don't you use `MacroAssembler::load_on_condition_imm_64` ? I think
> that's what you want to achieve here, right ?
> Although this check doesn't make that much sense, because I don't know if
> anyone is using z13 machine at all. But still if you want to put a check then
> please note that we need `has_LoadStoreConditional2` for `z_locghi`.
I think it would be better to just remove it then if no one is using z13
machines.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31984#discussion_r3849516082
