John Fischer wrote: > Jan, > > I know that you asked Jean and Alok to review ... :-) > > I noticed that in the below code points to the boot_archive_archive > file and saw that the name for the 64-bit and 32-bit files was > inconsistent. One ends in '.py' while the other does not. Other then > it always being this way is there another reason? Should this be fixed? > > Thanks, > > John
John, I reviewed this too. A symlink is created for /usr/share/distro_const/boot_archive_archive_32 to point to /usr/share/distro_const/boot_archive_archive.py. The finalizer doesn't want 2 finalizer scripts with the same name. Joe > >> <script >> name="/usr/share/distro_const/boot_archive_archive.py"> >> <checkpoint >> name="ba-arch" >> ! message="Boot >> archive archiving (64-bit)"/> >> ! <argslist>"amd64"</argslist> >> ! </script> >> ! <script >> name="/usr/share/distro_const/boot_archive_archive_32"> >> ! <checkpoint >> ! name="ba-arch-32" >> ! message="Boot >> archive archiving (32-bit)"/> >> ! <argslist>"x86"</argslist> >> </script> > > > > Jan Damborsky wrote: >> Hi Jean, Alok, >> >> could I please ask you to review fix for following bugs ? >> >> <http://defect.opensolaris.org/bz/show_bug.cgi?id=7966>7966 setting >> 'livemode=text' is no-op for AI, should be removed from installadm(1M) >> 8140 Fix for 6440 applied to x86 AI images would reduce x86 AI memory >> consumption >> >> >> Thank you very much, >> Jan >> >> webrev: >> http://cr.opensolaris.org/~dambi/bug-8140/ >> >> testing done: >> please see attachment for tests carried out and results >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
