Hi Jean, jeanm wrote: > installadm-common.sh: > Are we at all concerned with the case of an image that might exist > with the amd64 boot_archive a link to the 32 bit one?
I am not sure how we could end up with this case - you mean that boot archive with 64 bit stuff wouldn't exist at all ? > Is there any way of combining the two if's into one? Just seems a > little awkward to check for basically the same thing in two different > ways. Agreed - I have removed the first 'if' - it is redundant. I have also added comment describing covered scenarios. The webrev has been updated accordingly. > Also seems like we could end up with an issue if x86.microroot and the > 64 bit boot_archive both existed. Not that that is likely. I concur with Dave that this case would mean that AI image is malformed and that should be covered by other mechanisms, here is too late. Thank you very much for review ! Jan
