Thank you for catching that. I've made the statement before end with a
full-stop and left the capitalization.
Thank you,
Clay
On Mon, 3 Aug 2009, Keith Mitchell wrote:
> Works for me, with the minor note that "You" is randomly capitalized on line
> 66 ("...is called, You need...").
>
> Clay Baenziger wrote:
>> Hi all,
>> I think I've further addressed:
>> * Defaults and when to change the SPRO_ROOT variable (however, I
>> don't think it's germane to the README to explain how to track
>> your compilers down)
>> * I've removed mention of the ONBLD_TOOLS variable as it's less
>> likely one would want to change it now
>> * I think I've clarified the nightly verse nightly -n description
>> * I've broken the README out into three tasks due to their
>> likelihood of occurrence:
>> Setting up a build machine (once a machine)
>> Setting up a repo (once a pull)
>> Building a repo (every build)
>> I have left these tasks in opposite of how often they'll be used
>> so that people just building will have to see the requirements
>> for a build machine and setting up a repo (hopefully having them
>> take note of requirements before thinking they've hit a snag
>> in their code or the gate).
>> * I've also updated the developer.sh file which is shipped by
>> default to have more sane defaults
>> * Oh, and I missed updating the copyright which has now been fixed
>>
>> New webrev at:
>> http://cr.opensolaris.org/~clayb/9165/webrev1
>>
>> Thank you,
>> Clay
>>
>> On Mon, 3 Aug 2009, Keith Mitchell wrote:
>>
>>> Looks good, Clay. Two suggestions:
>>>
>>>> 39 You may need to set the paths for your build tools
>>>> 40 (the ONBLD_TOOLS variable) and the path for your compilers
>>>> 41 (the SPRO_ROOT variable).
>>>>
>>> I think it's worthwhile to indicate the defaults.
>>>
>>>> 77 7. Finally, to build, run: ./nightly developer.sh
>>>> 78 Which builds the source from the downloaded repository.
>>>>
>>> The wording still seems slightly off here. May I suggest
>>>
>>> Build the source by running: ./nightly developer.sh
>>> This will pull the source from the downloaded repository.
>>>
>>> - Keith
>>>
>>> Clay Baenziger wrote:
>>>> Hello, I'm looking for someone to review my English in the changes made
>>>> to our gate's README. I've tried answering bug 9165 and making other good
>>>> hygiene clean-ups.
>>>>
>>>> Webrev:
>>>> http://cr.opensolaris.org/~clayb/9165/
>>>> Bug:
>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=9165
>>>> Thank you,
>>>> Clay
>>>> _______________________________________________
>>>> caiman-discuss mailing list
>>>> caiman-discuss at opensolaris.org
>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>
>>
>> On Mon, 3 Aug 2009, Sanjay Nadkarni wrote:
>>
>>> On 08/ 3/09 10:50 AM, Clay Baenziger wrote:
>>>> Hello, I'm looking for someone to review my English in the changes made
>>>> to our gate's README. I've tried answering bug 9165 and making other good
>>>> hygiene clean-ups.
>>>>
>>>> Webrev:
>>>> http://cr.opensolaris.org/~clayb/9165/
>>>> Bug:
>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=9165
>>>> Thank you,
>>>> Clay
>>>> _______________________________________________
>>>> caiman-discuss mailing list
>>>> caiman-discuss at opensolaris.org
>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>> LGTM
>>>
>>> -Sanjay
>>>
>>>
>>
>> On Mon, 3 Aug 2009, Sue Sohn wrote:
>>
>>> Clay Baenziger wrote:
>>>> Hello, I'm looking for someone to review my English in the changes made
>>>> to our gate's README. I've tried answering bug 9165 and making other good
>>>> hygiene clean-ups.
>>>>
>>>> Webrev:
>>>> http://cr.opensolaris.org/~clayb/9165/
>>>> Bug:
>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=9165
>>>> Thank you,
>>>> Clay
>>>> _______________________________________________
>>>> caiman-discuss mailing list
>>>> caiman-discuss at opensolaris.org
>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>
>>> Hi Clay,
>>>
>>> Looks good for the most part.
>>>
>>> 38 It isn't clear how one knows whether they need to set these variables.
>>>
>>> 78 Maybe reword slightly:
>>> Finally, to build, run: ./nightly developer.sh
>>> Which builds the source from the downloaded repository.
>>>
>>> If you do not wish to do a Mercurial pull as part of the nightly run,
>>> use the -n option.
>>>
>>> ./nightly -n developer.sh
>>>
>>> ->
>>>
>>> Finally, to build the source from a downloaded repository,
>>> run:
>>>
>>> ./nightly developer.sh
>>>
>>> If you do not wish to do a Mercurial pull as part of the nightly run,
>>> use the -n option:
>>>
>>> ./nightly -n developer.sh
>>>
>>>
>>> Thanks,
>>> Sue
>>>
>>
>> On Mon, 3 Aug 2009, Moriah Waterland wrote:
>>
>>> Clay,
>>>
>>> Overall it looks good. However, I recommend splitting out the items
>>> that are related to setting your build environment into a separate
>>> section preceding the section about building your repository. Something
>>> like the following:
>>>
>>>> To set up your build machine or environment use the following steps:
>>>> 1. Get the SunStudio compilers via the Image Packaging System (IPS). To
>>>> install
>>>> run the command "pfexec pkg install sunstudioexpress"
>>>>
>>>> 2. Get the OS/Net Build Tools via the Image Packaging System (IPS). To
>>>> install
>>>> run the command "pfexec pkg install SUNWonbld"
>>>>
>>>> 3. Install the three OS/Net Consolidation packages required:
>>>> * SUNWzoneint
>>>> * SUNWldskint
>>>> * SUNWwbint
>>>> To get these packages, one can download them from
>>>> http://dlc.sun.com/osol/install/downloads/current/
>>>
>>>> To build this repository use the following steps:
>>>>
>>>> 1. cd usr/src in the repository
>>>>
>>>> 2. cp tools/env/developer.sh .; chmod +w developer.sh.
>>>>
>>>> Change GATE and/or CODEMGR_WS as appropriate.
>>>>
>>>> You may need to set the paths for your build tools
>>>> (the ONBLD_TOOLS variable) and the path for your compilers
>>>> (the SPRO_ROOT variable).
>>>>
>>>> 3. Copy the nightly build script found in /opt/onbld/bin into the
>>>> usr/src directory.
>>>>
>>>> cp /opt/onbld/bin/nightly .; chmod +w nightly
>>>>
>>>> In the nightly script there are three places
>>>> where getopts is called, You need to add a "+" to two of them.
>>>>
>>>> while getopts +inS:tV: FLAG
>>>> ^
>>>> and
>>>>
>>>> while getopts +AaBCDdFfGIilMmNnOoPpRrS:TtUuWwXxz FLAG
>>>> $NIGHTLY_OPTIONS
>>>> ^
>>>>
>>>> If you choose not to set these, you will see warning messages
>>>> regarding building tools. It won't affect your build otherwise.
>>>>
>>>> For more information see bug 849 -
>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=849
>>>>
>>>> 4. Finally, to build, run: ./nightly developer.sh
>>>> Which builds the source from the downloaded repository.
>>>> If you do not wish to do a Mercurial pull as part of the nightly
>>>> run,
>>>> use the -n option.
>>>>
>>>> ./nightly -n developer.sh
>>>>
>>>>
>>>
>>> thanks,
>>> Moriah
>>>
>>>
>>> Clay Baenziger wrote:
>>>> Hello, I'm looking for someone to review my English in the changes made
>>>> to our gate's README. I've tried answering bug 9165 and making other good
>>>> hygiene clean-ups.
>>>>
>>>> Webrev:
>>>> http://cr.opensolaris.org/~clayb/9165/
>>>> Bug:
>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=9165
>>>> Thank you,
>>>> Clay
>>>> _______________________________________________
>>>> caiman-discuss mailing list
>>>> caiman-discuss at opensolaris.org
>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>
>
