Hi Jean, Thank you for your code review.
I changed it to preferred authority instead of main. It's actually better that way, because it is consistent with the terminology that IPS uses. I added the post_install info too. Here's the updated webrev with the above changes, plus merging with the putback you did. http://cr.opensolaris.org/~ktung/bugfixes_mod/ Thanks, --Karen Jean McCormack wrote: > DC_tm.py: > line 201-202,221: Nit. Maybe preferred authority instead of main? > > Should we be printing out the post_install info too? > > Rest looks fine. > > Jean > > Karen Tung wrote: >> Hi, >> >> Please do a code review for changes that fixed the following: >> >> 3707 Distro constructor should output config info at start of build >> 3999 Create a manifest for generating the global CD >> 3871 stderr output from python finalizer scripts don't show up in DC >> logfiles >> >> webrev: >> >> http://cr.opensolaris.org/~ktung/bugfixes/ >> >> Thanks, >> >> --Karen >> >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
