Hi Jack, Thanks again for looking over the updated code. My responses inline below. I think we have resolved all the issues. I will push after Jean pushes her changes, as we discuss in the meeting today.
Jack Schwartz wrote: > Hi Karen. > > Lookin' good! Couple of things, responses in line. > > OK. > > But I would like to see in slim_cd.xml a comment that that file builds > a limited language OpenSolaris live CD iso and USB image. This helps > make it clearer what the differences between the two files are. OK, added comment to slim_cd.xml. >> >> >> The updated webrev with all the changes are available at: >> >> http://cr.opensolaris.org/~ktung/bugfixes_mod2/ >> >> Can you check it out to make sure everything is ok? > distro_const.py: 320: Nit:It would be clearer to me to see the > distribution name before anything else (except the start time). Change as suggested. > > The rest looks fine to me. > > Thanks again for the code review, Jack. --Karen
