OK. Sounds reasonable. I'll make it no default and if the user doesn't fill anything in, i.e. the read of the manifest returns None, we'll just start from the beginning.
Jean Karen Tung wrote: > Hi Jean, > > I have 2 comments. > > - DC-manifest.defval.xml: in this file, there's the default value > setting for > the resume_from field. It's currently set to 1. In my opinion, there > shouldn't > be any default for this field. > > - In all the 3 manifests, you changed the original value from 1 to > im-pop. > I think it would be best to not specify anything for the resume_from > step name. > That way, in case the first step is not im-pop in the future, we don't > have to > change the manifest for this. Whatever is the first step will get > executed. > > Thanks, > > --Karen > > Jean McCormack wrote: >> Can Jack and Karen please review the following >> >> >> Defect: >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4127 >> >> Webrev: >> http://cr.opensolaris.org/~jeanm/slim_4127/ >> >> >> Jean >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
