Dermot, You should include a webrev of the actual changes you've made so that there is some code changes to review :)
generate the code changes using webrev -O, and scp the resulting directory to cr.opensolaris.org. cheers Matt Dermot McCluskey wrote: > Hi, > > Can I get a code review for this simple fix for: > > Bug 12740 - Makefiles link directly to mediaLib > http://defect.opensolaris.org/bz/show_bug.cgi?id=12740 > > > Testing performed: > - did full nightly build > - confirmed resulting gui-install binary no longer links > against libmlib > - built iso with dc containing new SUNWgui-install pkg > - confirmed iso boots and gui-install runs as expected > and is not linking against libmlib when running. > > > Dermot > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
