Dermot McCluskey wrote: > Evan, > > I believe -z defs is enabled by default when building executables, > as is the case here (/usr/bin/gui-install is the only installed > binary built from these Makefiles). > > In any event, I did ldd on the binary, which should catch missing > symbols/libs.
Ok good enough. It was just a nit anyway. ;-) The reason I had suggested it is that when it's used it forces the dependency checking when we build and catches things a bit easier (sometimes...). > > > As for the long lines, I usually try to disturb as little code > as possible, to make reviewing easier, but if your prefer "clean > as you go" I can do that instead? The clean as you go is fine with me and this is also just a nit and not a problem with your changes. Plus this was how things were originally so it's not really a big deal. Anyway I'm fine with pushing what you have and cleaning up as we go. Thanks, -evan > > > - Dermot > > > > > On 12/03/09 16:37, Evan Layton wrote: >> Hi Dermot, >> >> Should we be using -zdefs in these so that we make sure we're defining >> all of the library dependencies we have? Also these lines seem really >> long it might be good to use line continuations to make this a bit >> more readable. I think this needs to be done for both PACKAGE_CFLAGS >> and PACKAGE_LIBS in all three make files. >> >> Thanks, >> >> -evan >> >> Dermot McCluskey wrote: >>> Here's the link to the webrev: >>> http://cr.opensolaris.org/~dermot/webrev-12740-01/ >>> >>> >>> - Dermot >>> >>> >>> >>> >>> On 12/03/09 15:47, Dermot McCluskey wrote: >>>> Hi, >>>> >>>> Can I get a code review for this simple fix for: >>>> >>>> Bug 12740 - Makefiles link directly to mediaLib >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=12740 >>>> >>>> >>>> Testing performed: >>>> - did full nightly build >>>> - confirmed resulting gui-install binary no longer links >>>> against libmlib >>>> - built iso with dc containing new SUNWgui-install pkg >>>> - confirmed iso boots and gui-install runs as expected >>>> and is not linking against libmlib when running. >>>> >>>> >>>> Dermot >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>
