Hi Dermot, Should we be using -zdefs in these so that we make sure we're defining all of the library dependencies we have? Also these lines seem really long it might be good to use line continuations to make this a bit more readable. I think this needs to be done for both PACKAGE_CFLAGS and PACKAGE_LIBS in all three make files.
Thanks, -evan Dermot McCluskey wrote: > Here's the link to the webrev: > http://cr.opensolaris.org/~dermot/webrev-12740-01/ > > > - Dermot > > > > > On 12/03/09 15:47, Dermot McCluskey wrote: >> Hi, >> >> Can I get a code review for this simple fix for: >> >> Bug 12740 - Makefiles link directly to mediaLib >> http://defect.opensolaris.org/bz/show_bug.cgi?id=12740 >> >> >> Testing performed: >> - did full nightly build >> - confirmed resulting gui-install binary no longer links >> against libmlib >> - built iso with dc containing new SUNWgui-install pkg >> - confirmed iso boots and gui-install runs as expected >> and is not linking against libmlib when running. >> >> >> Dermot >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
