Hi Karen,
Thanks for having a second look at this.
* Karen Tung (Karen.Tung at Sun.COM) wrote:
Joe has responded to all of your comments except this one which I'll
tackle.
> usr/src/cmd/distro_const/vmc/vmc_image.xml
> * Some previous discussion of code review comments mentioned
> that you will add a "flag post" to this file telling ppl what people
> most like will modify or not, but I don't see this in the file yet.
I agree that we did discuss this and I said I would add a "flag post",
however looking at the vmc manifest now I don't know that it makes any
sense to do so. People will be modifying the finalizer section of the
manifest to customize the VM configuration. The only thing in the
manifest after the finalizer section (after I address your comment about
moving distro_constr_flags) is:
</output_image>
</distro_constr_params>
<!--
Currently, vmimg_params contains no data. It's merely
used
to differentiate manifests which create media images
from
those that don't.
-->
<vmimg_params>
</vmimg_params>
</distribution>
I could add a "flag post" after the closing distro_constr_params tag but
that doesn't seem terribly useful to me.
> * Also, I remembered that we will move the <distro_constr_flags>
> section to be in front of the <finalizer>section since
> distro_const_flags will more likely be modified, while the finalizer scripts
> sections is less likely to be modified.
Fixed.
> * For the "export-esx" and "export-ovf" checkpoints, do you mean the
> script name to be /usr/share/distro_const/vmc/export_vm? The 2 scripts
> listed are removed, right?
No, we deliver symlinks to export_vm by those names (much like what is
done for boot_archive_archive.py.
Thanks Karen!
--
Glenn
