Jan, auto_td.c: auto_select_install_target RE: order or evaluation. c#t#d# formate precedes more deterministic means, including: physical path, volume name. Shouldn't the evaluation of the more consistent and deterministic tags precede the less reliable c#t#d#?
Should the "sanity check" have an assert()? disk_criteria_match(): log message: "Searching for a disk target matching the following criteria:\n" disk_util.c: local_free_disk_info should return the strings allocated in copy_disk_info_data(). td_api.h: what does OPATH in TD_DISK_ATTR_OPATH stand for? William Jan Damborsky wrote: > Hi William, > > could I please ask you to review fix for following AI bugs > related to selecting the target disk via AI manifest ? > > 5451 No way to permanently target specific disk in AI engine manifest > 7057 desire for being able to specify boot disk as installation target > in AI manifest > 7058 desire for being able to pick up disk as installation target by > specifying volume name in AI manifest > > Thank you very much, > Jan > > * Webrev > http://cr.opensolaris.org/~dambi/bug-7057/ > > > * Modules affected > - AI manifest > - Target Discovery > - Orchestrator > - AI engine > > * Test procedures > http://cr.opensolaris.org/~dambi/ai_disk_selection-test/test-procedures.txt > > > * Test results > http://cr.opensolaris.org/~dambi/ai_disk_selection-test/ >
