Jan, Jan Damborsky wrote: > > William Schumann wrote: >> auto_install.c: >> 756: iSCSI boot target might be identified and mounted, but 807 >> auto_select_install_target() does not automatically select it. > > Hmm, looking at the code, the logic around selecting the iSCSI disk was > not changed - could you please elaborate more on why it should not work ? I see now that it would work. Never mind. >> >> The changes making the manifest elements mutually exclusive warrants >> a release note, since it will break manifests, formerly passing >> validation, now failing with a confusing error message. The most >> likely case of this is combining the device name tag with the group 2 >> tags. This point in the doc should be updated, too. > > Agreed. These are actions which I think would help to mitigate that > problem: > > * behavior is documented in AI schema > * Flag day will be sent out to make people aware of this behavior > * I will follow up with Barbara on documentation part I think that existing sample manifests might be broken as well. > > Also, I am wondering that in case validation fails, if it might be useful > to capture output of xmllint(1) (delivered by SUNWlxml package ) in > /tmp/install_log - > the output looks like > > # xmllint --noout --relaxng /tmp/ai_manifest.rng /tmp/ai_manifest.xml > Relax-NG validity error : Extra element ai_target_device in interleave > /tmp/ai_manifest.xml:2: element ai_target_device: Relax-NG validity > error : Element ai_manifest failed to validate content > /tmp/ai_manifest.xml fails to validate This is identical to the ManifestServ output that we are not not capturing. > This would provide user with initial clue what section of AI manifest > is the problematic one and what the potential issue is. > > Please let me know what you think. I think xmllint would be the easiest way to capture the output and that it would be a big improvement.
Thanks, William
