Hi William, thank you very much for code review. Please see my response in line.
Jan William Schumann wrote: > Jan, > auto_td.c: auto_select_install_target > RE: order or evaluation. c#t#d# formate precedes more deterministic > means, including: physical path, volume name. Shouldn't the evaluation > of the more consistent and deterministic tags precede the less > reliable c#t#d#? This is a good point. As we have discussed, deterministic attributes will have the highest priority and will be processed first. So we would end up with three groups of attributes: G1 - boot disk, devid, physical path, volume name G2 - ctd name G3 - rest of attributes (vendor, bus type, ...) attributes in G1 and G2 will be mutually exclusive, e.g. only one could be specified in AI manifest. They will be also mutually exclusive with G3 as a whole. AI schema will be modified to enforce that policy. Please let me know if it reflects correctly what has been discussed. Also, once we sort this out, I'll update bug reports accordingly. > > Should the "sanity check" have an assert()? Yes - will add. > > disk_criteria_match(): log message: > "Searching for a disk target matching the following criteria:\n" Will change. > > disk_util.c: local_free_disk_info should return the strings allocated > in copy_disk_info_data(). Thank you for catching this - I will add this code. > > td_api.h: what does OPATH in TD_DISK_ATTR_OPATH stand for? According to libdiskmgt spec, it stands for "A raw devpath which can open the drive; ..." Its format is "/dev/rdsk/c#[t#]d#s0"
