Hi William,

William Schumann wrote:
> Jan,
> The comments in the sample should be enormously helpful to users.  
> Looking at the sample more closely, I would recommend a few changes.
>
> Remove 
> <target_device_overwrite_root_zfs_pool>true</target_device_overwrite_root_zfs_pool>
>  
>
> since it has not yet been implemented.

I agree - removed.

>
> Put 
> <target_device_use_solaris_partition>true</target_device_use_solaris_partition>
>  
>
> in comments and add a comment saying: Uncomment this to force AI to 
> find an existing Solaris partition instead of creating a new one.

Changed.

>
> Also, in looking at the supporting code, there are 2 references to 
> FD_NUMPART that should be updated to OM_NUMPART to support logical 
> partitions.

I have changed those accordingly and updated the webrev:

http://cr.opensolaris.org/~dambi/bug-7057-cr/

Thank you,
Jan


Reply via email to