Hi Evan.
Here are my comments:
be_utils.c:
3453-3461: have you considered using dirname(3C) for this?
3459: Is this an appropriate error, or would it be better to have an
error that the menu_path is invalid as it is missing "menu.lst"?
tbeadm/Makefile:
How come both Makefiles need the change to include libgen? Does
be_utils.c get compiled by both Makefiles?
ict.py:
305: typo: durring -> during
328: logic appears inverted
334,336: I would expect different comments for these two lines as 334
has BASEDIR added
Thanks,
Jack
On 10/09/09 00:47, Evan Layton wrote:
> I need to get reviews for the following bugs that are causing failures
> if the directories where the boot/grub menu files live are missing
> (/rpool/boot and /rpool/boot/grub). Also this fix resolves the issue
> with the add_splash_image_to_grub_menu that was causing a failure to
> create a menu.lst file when it's missing.
>
>
> The bugs:
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7880
> http://defect.opensolaris.org/bz/show_bug.cgi?id=11436
>
>
> The webrev:
> http://cr.opensolaris.org/~evanl/7880/
>
>
> Thanks,
> -evan
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
