Jack Schwartz wrote:
> Hi Evan.
>>>
>>> ict.py:
>>>
>>> 328: logic appears inverted
>>
>> Inverted in what way? If this is being run as part of a liveCD or 
>> Automated install then we don't want to allow the use of "/" as the 
>> base dir.
> What you say here makes more sense, but then the comments as I 
> understand them on 306-307 and 325-326 are incorrect: we should not 
> support / for BASEDIR on a live system.
> 
>    Thanks,
>    Jack
> 

You're right, the comments were a bit confusing here so I changed them
to make it a bit clearer:

325          '''
326          The code can be run on a live system but if we're not
327          on a live system we should not support / for BASEDIR.
328          '''

This is reflected in the new webrev (http://cr.opensolaris.org/~evanl/7880v2/)

Thanks!

-evan

Reply via email to